Use pos from GameDataLoader#55
Open
morganchristiansson wants to merge 1 commit into
Open
Conversation
Flamefire
requested changes
Jun 29, 2026
Flamefire
left a comment
Flamefire
left a comment
Member
There was a problem hiding this comment.
This looses the correctly animated textures which is actually missing in s25main. The editor is currently the only instance that (still) handles it correctly so we won't remove it and make it look worse.
And shouldn't we e.g. check maps for "known" textures on load instead of handling that in getTerrainDesc? I'm not sure the handling will still be correct in absence of terrain data.
| if(s2Id < map.s2IdToTerrain.size()) | ||
| { | ||
| const auto idx = map.s2IdToTerrain[s2Id]; | ||
| if(idx) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of current hardcoded values.
GameDataLoader loads them from data/RTTR/gamedata/world/*.lua
This also removes water animations as they use coordinate offsets rather than palette animation, which should be addressed in another PR.