feat: fallback front_female sprite to front_default for female-only p…

pokemon_v2/api.py

@@ -754,6 +754,11 @@ class PokemonResource(PokeapiCommonViewset):
     serializer_class = PokemonDetailSerializer
     list_serializer_class = PokemonSummarySerializer
 
+    def get_queryset(self):
+        if self.action == "retrieve":
+            return Pokemon.objects.all().select_related("pokemon_species")
+        return super().get_queryset()
+
 
 @extend_schema(
     description="A Pokémon Species forms the basis for at least one Pokémon. Attributes of a Pokémon species are shared across all varieties of Pokémon within the species. A good example is Wormadam; Wormadam is the species which can be found in three different varieties, Wormadam-Trash, Wormadam-Sandy and Wormadam-Plant.",

pokemon_v2/serializers.py

@@ -4418,7 +4418,34 @@ class Meta:
     )
     def get_pokemon_sprites(self, obj):
         sprites_object = PokemonSprites.objects.get(pokemon_id=obj)
-        return sprites_object.sprites
+        sprites = sprites_object.sprites
+        if obj.pokemon_species.gender_rate == 8:
+            if isinstance(sprites, str):
+                parsed = json.loads(sprites)
+                self._fill_female_sprites(parsed)
+                return json.dumps(parsed)
+            self._fill_female_sprites(sprites)
+        return sprites
+
+    _FEMALE_FALLBACKS = {
+        "front_female": "front_default",
+        "back_female": "back_default",
+        "front_shiny_female": "front_shiny",
+        "back_shiny_female": "back_shiny",
+    }
+
+    def _fill_female_sprites(self, node):
+        if not isinstance(node, dict):
+            return
+        for female_key, default_key in self._FEMALE_FALLBACKS.items():
+            if (
+                female_key in node
+                and node[female_key] is None
+                and node.get(default_key) is not None
+            ):
+                node[female_key] = node[default_key]
+        for value in node.values():
+            self._fill_female_sprites(value)
 
     @extend_schema_field(
         field={

pokemon_v2/tests.py

@@ -5257,6 +5257,36 @@ def test_pokemon_api(self):
         self.assertEqual(response.data["count"], 1)
         self.assertEqual(response.data["results"][0]["name"], pokemon.name)
 
+    def test_pokemon_api_female_only_sprites_fallback(self):
+        pokemon_species = self.setup_pokemon_species_data(
+            name="female only pkmn spcs", gender_rate=8
+        )
+        pokemon = self.setup_pokemon_data(
+            pokemon_species=pokemon_species, name="female only pkmn"
+        )
+        self.setup_pokemon_form_data(pokemon=pokemon, name="female only pkmn form")
+        pokemon_sprites = self.setup_pokemon_sprites_data(
+            pokemon=pokemon, front_default=True, front_female=False
+        )
+        self.setup_pokemon_cries_data(pokemon, latest=True, legacy=True)
+
+        response = self.client.get(
+            "{}/pokemon/{}/".format(API_V2, pokemon.pk), headers={"host": "testserver"}
+        )
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        sprites_data = json.loads(pokemon_sprites.sprites)
+        response_sprites = json.loads(response.data["sprites"])
+
+        self.assertIsNotNone(response_sprites["front_default"])
+        self.assertEqual(
+            response_sprites["front_female"], response_sprites["front_default"]
+        )
+        self.assertEqual(
+            response_sprites["other"]["showdown"]["front_female"],
+            response_sprites["other"]["showdown"]["front_default"],
+        )
+
     def test_pokemon_form_api(self):
         pokemon_species = self.setup_pokemon_species_data()
         pokemon = self.setup_pokemon_data(pokemon_species=pokemon_species)