refactor(app): Port Wi-Fi disconnect from redux-observable to react-query#21783
Open
SyntaxColoring wants to merge 4 commits into
Open
refactor(app): Port Wi-Fi disconnect from redux-observable to react-query#21783SyntaxColoring wants to merge 4 commits into
SyntaxColoring wants to merge 4 commits into
Conversation
SyntaxColoring
force-pushed
the
port_wifi_disconnect
branch
from
f55278c to
b0b4503
Compare
SyntaxColoring
requested review from
a team,
TamarZanzouri,
janiejaffe and
sfoster1
and removed request for
a team
SyntaxColoring
force-pushed
the
port_wifi_disconnect
branch
from
b0b4503 to
80ea4cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This ports the desktop app's "disconnect from Wi-Fi" button from redux-observable to react-query to prepare it for Compliance Ready Software. This continues from #21767 and is another chunk of AUTH-2976.
Test Plan and Hands on Testing
Screen.Recording.2026-06-17.at.3.54.31.PM.mov
Changelog
This is mostly a direct port. There wasn't anything special in the Redux layer. The catch here is that this code was doing "special stuff" with pending and failed requests, so we need to be careful to translate those concepts correctly.
Review requests
Just double-check my new logic in 9fbec16.
Risk assessment
Medium because of the special stuff with pending and failed requests.