Skip to content

Add Hebrew (he) translation + externalize hardcoded ACP strings#25

Open
palmoni5 wants to merge 2 commits into
NodeBB:mainfrom
palmoni5:add-hebrew-translation
Open

Add Hebrew (he) translation + externalize hardcoded ACP strings#25
palmoni5 wants to merge 2 commits into
NodeBB:mainfrom
palmoni5:add-hebrew-translation

Conversation

@palmoni5

@palmoni5 palmoni5 commented Jun 23, 2026

Copy link
Copy Markdown

What

  • Adds a Hebrew (he) translation under languages/he/openai.json.
  • Externalizes the previously hardcoded English strings in the ACP settings template (templates/admin/plugins/openai.tpl) into [[openai:admin.*]] translation keys — section headers, labels, input titles, help texts and the system-prompt placeholder.
  • Replaces the hardcoded OK button label in public/lib/main.js with the built-in [[global:ok]].
  • Adds the new English keys to both en-GB and en-US, and full Hebrew values to he.

Notes

  • The "Create a user" help link keeps {config.relative_path} by passing it as %1 to [[openai:admin.chatgpt-username-help, ...]], so the link still resolves correctly after translation.
  • Model option values (e.g. gpt-4o) are identifiers and intentionally left untranslated.

palmoni5 added 2 commits June 23, 2026 19:43
נוספה תיקיית languages/he עם תרגום הודעות התוסף לעברית.
הוצאו כל הכותרות, התוויות וטקסטי העזרה הקשיחים בתבנית ה-ACP
למפתחות תרגום (openai:admin.*), וכן תווית כפתור "OK" שעברה ל-global:ok.
נוספו הערכים בשלוש השפות en-GB, en-US ו-he.
@palmoni5 palmoni5 changed the title Add Hebrew (he) translation Add Hebrew (he) translation + externalize hardcoded ACP strings Jun 23, 2026
@palmoni5

Copy link
Copy Markdown
Author

@barisusakli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant