Fix FULL OUTER JOIN COALESCE in MIMIC-IV height concept#2015
Open
Chessing234 wants to merge 1 commit into
Open
Fix FULL OUTER JOIN COALESCE in MIMIC-IV height concept#2015Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Rows from ht_in with no matching ht_cm row were dropped because COALESCE used h1 columns twice instead of falling back to h2. Fixes MIT-LCP#2010. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ht_stg0in MIMIC-IVheight.sqlto useh2columns inCOALESCEfallbacks forsubject_id,stay_id, andcharttimeProblem
The FULL OUTER JOIN between inch-based (
ht_in) and cm-based (ht_cm) height measurements usedCOALESCE(h1.col, h1.col), which never falls back toh2values. Height records present only inht_inwere excluded from the derived table.Test plan
mimiciv_derived.heightand verify inch-only measurements are retainedFixes #2010
Made with Cursor