tests: make RT properly start/stop in the raster test#4213
Open
BsAtHome wants to merge 1 commit into
Open
Conversation
Contributor
|
Due to you have a PR open already: Probably a bad idea. The only reason this works is due to runtests first checks for *.hal. |
BsAtHome
force-pushed
the
fix_raster-test-rtstartstop
branch
from
5ef689f to
32f749d
Compare
Contributor
Author
|
You are right, accident waiting to happen. Updated PR to fix by renaming test.py into streamtest.py. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTAI did not pass the raster test because RT was not started properly. This should fix the situation by using a halrun wrapper as already provided by the run_tests script.
As discussed in #4206 to start/stop RT for the raster test in the correct order.