fix: Update rest session manager when logging in#1569
Open
tpoliaw wants to merge 2 commits into
Open
Conversation
If the user is not logged in when the client is created, the rest client does not get a session manager. When the user calls login, a new session manager is created to cache the new token but if the rest client is not updated, any subsequent calls remain unauthenticated. Setting the rest client's session manager to the new instance when a login is successful means the tokens can be used without recreating the client. Now that the login method works as expected, the client created in the `just repl` task can now automatically refresh its login if required.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1569 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 44 44
Lines 3255 3256 +1
=======================================
+ Hits 3122 3123 +1
Misses 133 133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user is not logged in when the client is created, the rest client
does not get a session manager. When the user calls login, a new session
manager is created to cache the new token but if the rest client is not
updated, any subsequent calls remain unauthenticated.
Setting the rest client's session manager to the new instance when a
login is successful means the tokens can be used without recreating the
client.
Now that the login method works as expected, the client created in the
just repltask can now automatically refresh its login if required.