refactor: Unify call-actor tool across default and apps modes (#980)

## What

- Single `createCallActorTool(description)` definition in
`default/call_actor.ts`; `defaultCallActor` and `appsCallActor` are
built from it, differing only in description (apps appends the widget
addendum).
- Deletes the duplicated `apps/call_actor.ts`.
- `categories.ts` mode map unchanged — registry behavior is identical.

closes #975

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: 3 people

src/tools/apps/call_actor.ts

@@ -22,7 +22,6 @@
 import { HelperTools } from '../const.js';
 import type { ToolEntry } from '../types.js';
 import { ServerMode } from '../types.js';
-import { appsCallActor } from './apps/call_actor.js';
 import { appsCallActorWidget } from './apps/call_actor_widget.js';
 import { fetchActorDetailsWidgetTool } from './apps/fetch_actor_details_widget.js';
 import { getActorRunWidgetTool } from './apps/get_actor_run_widget.js';
@@ -41,16 +40,11 @@ import { getKeyValueStoreRecord } from './common/get_key_value_store_record.js';
 import { getUserKeyValueStoresList } from './common/key_value_store_collection.js';
 import { getUserRunsList } from './common/run_collection.js';
 import { searchApifyDocsTool } from './common/search_apify_docs.js';
-import { defaultCallActor } from './default/call_actor.js';
+import { appsCallActor, defaultCallActor } from './default/call_actor.js';
 import { defaultFetchActorDetails } from './default/fetch_actor_details.js';
 import { defaultGetActorRun } from './default/get_actor_run.js';
 import { defaultSearchActors } from './default/search_actors.js';
 
-/**
- * A mode map: maps one or more ServerMode keys to their ToolEntry variant.
- * - All modes present → each mode gets its own implementation
- * - Subset of modes → tool is only included for those modes
- */
 type ModeMap = Partial<Record<ServerMode, ToolEntry>>;
 
 /** A category tool entry: plain ToolEntry (mode-independent) or a mode map. */

src/tools/categories.ts

@@ -2,36 +2,47 @@ import { HelperTools } from '../../const.js';
 import type { InternalToolArgs, ToolEntry } from '../../types.js';
 import { TOOL_TYPE } from '../../types.js';
 import {
+    buildCallActorAppsDescription,
     buildCallActorDescription,
     callActorAjvValidate,
     callActorInputSchema,
     executeCallActor,
 } from '../core/call_actor_common.js';
 import { getActorRunOutputSchema } from '../structured_output_schemas.js';
 
-const CALL_ACTOR_DEFAULT_DESCRIPTION = buildCallActorDescription();
+/**
+ * Single call-actor definition shared by both modes — only the description differs
+ * (apps mode appends a widget addendum).
+ */
+function createCallActorTool(description: string): ToolEntry {
+    return Object.freeze({
+        type: TOOL_TYPE.INTERNAL,
+        name: HelperTools.ACTOR_CALL,
+        description,
+        inputSchema: callActorInputSchema,
+        outputSchema: getActorRunOutputSchema,
+        ajvValidate: callActorAjvValidate,
+        paymentRequired: true,
+        annotations: {
+            title: 'Call Actor',
+            readOnlyHint: false,
+            destructiveHint: true,
+            idempotentHint: false,
+            openWorldHint: true,
+        },
+        execution: {
+            // Support long-running tasks
+            taskSupport: 'optional',
+        },
+        call: async (toolArgs: InternalToolArgs) => executeCallActor(toolArgs),
+    } as const);
+}
+
+/** Default mode call-actor tool. */
+export const defaultCallActor: ToolEntry = createCallActorTool(buildCallActorDescription());
 
 /**
- * Default mode call-actor tool.
+ * Apps mode call-actor tool.
+ * Renders no widget; for a live progress UI, use the call-actor-widget sibling.
  */
-export const defaultCallActor: ToolEntry = Object.freeze({
-    type: TOOL_TYPE.INTERNAL,
-    name: HelperTools.ACTOR_CALL,
-    description: CALL_ACTOR_DEFAULT_DESCRIPTION,
-    inputSchema: callActorInputSchema,
-    outputSchema: getActorRunOutputSchema,
-    ajvValidate: callActorAjvValidate,
-    paymentRequired: true,
-    annotations: {
-        title: 'Call Actor',
-        readOnlyHint: false,
-        destructiveHint: true,
-        idempotentHint: false,
-        openWorldHint: true,
-    },
-    execution: {
-        // Support long-running tasks
-        taskSupport: 'optional',
-    },
-    call: async (toolArgs: InternalToolArgs) => executeCallActor(toolArgs),
-} as const);
+export const appsCallActor: ToolEntry = createCallActorTool(buildCallActorAppsDescription());

src/tools/default/call_actor.ts

@@ -6,8 +6,8 @@ import { afterEach, describe, expect, it, vi } from 'vitest';
 import { HelperTools, SERVER_MODE_AUTO_DETECTION_ENABLED } from '../../src/const.js';
 import { ActorsMcpServer } from '../../src/mcp/server.js';
 import { RESOURCE_MIME_TYPE } from '../../src/resources/widgets.js';
-import { appsCallActor } from '../../src/tools/apps/call_actor.js';
 import { searchActorsWidgetTool } from '../../src/tools/apps/search_actors_widget.js';
+import { appsCallActor } from '../../src/tools/default/call_actor.js';
 import { defaultSearchActors } from '../../src/tools/default/search_actors.js';
 import type { ServerModeOption } from '../../src/types.js';
 import { ServerMode } from '../../src/types.js';

tests/unit/mcp.server.capability_gating.test.ts

@@ -47,7 +47,8 @@ describe('getCategoryTools', () => {
         const appsNames = appsResult.actors.map((t: ToolEntry) => t.name);
         expect(defaultNames).toEqual(appsNames);
 
-        // call-actor still has mode-specific variants (sync-capable default vs always-async apps).
+        // call-actor still has mode-specific variants — distinct objects differing only in
+        // description (apps mode appends a widget addendum).
         // search-actors and fetch-actor-details are mode-independent and share the same object.
         const defaultCallActor = defaultResult.actors.find((t: ToolEntry) => t.name === HelperTools.ACTOR_CALL);
         const appsCallActor = appsResult.actors.find((t: ToolEntry) => t.name === HelperTools.ACTOR_CALL);